[Lldb-commits] [lldb] r124905 - in /lldb/trunk: source/Commands/ test/alias_tests/ test/array_types/ test/bitfields/ test/breakpoint_command/ test/breakpoint_conditions/ test/breakpoint_ignore_count/ test/breakpoint_locations/ test/class_types/ test/dead-strip/ test/enum_types/ test/forward/ test/function_types/ test/global_variables/ test/load_unload/ test/set_values/ test/signal/ test/signed_types/ test/stl/ test/struct_types/ test/unsigned_types/

Caroline Tice ctice at apple.com
Fri Feb 4 14:59:41 PST 2011


Author: ctice
Date: Fri Feb  4 16:59:41 2011
New Revision: 124905

URL: http://llvm.org/viewvc/llvm-project?rev=124905&view=rev
Log:
Change "breakpoint list" command to default to brief output rather than full output.

Modify test cases in test suite to either expect brief output or to pass -f for full
output as appropriate.


Modified:
    lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp
    lldb/trunk/test/alias_tests/TestAliases.py
    lldb/trunk/test/array_types/TestArrayTypes.py
    lldb/trunk/test/bitfields/TestBitfields.py
    lldb/trunk/test/breakpoint_command/TestBreakpointCommand.py
    lldb/trunk/test/breakpoint_conditions/TestBreakpointConditions.py
    lldb/trunk/test/breakpoint_ignore_count/TestBreakpointIgnoreCount.py
    lldb/trunk/test/breakpoint_locations/TestBreakpointLocations.py
    lldb/trunk/test/class_types/TestClassTypes.py
    lldb/trunk/test/dead-strip/TestDeadStrip.py
    lldb/trunk/test/enum_types/TestEnumTypes.py
    lldb/trunk/test/forward/TestForwardDeclaration.py
    lldb/trunk/test/function_types/TestFunctionTypes.py
    lldb/trunk/test/global_variables/TestGlobalVariables.py
    lldb/trunk/test/load_unload/TestLoadUnload.py
    lldb/trunk/test/set_values/TestSetValues.py
    lldb/trunk/test/signal/TestSendSignal.py
    lldb/trunk/test/signed_types/TestSignedTypes.py
    lldb/trunk/test/stl/TestSTL.py
    lldb/trunk/test/struct_types/TestStructTypes.py
    lldb/trunk/test/unsigned_types/TestUnsignedTypes.py

Modified: lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp Fri Feb  4 16:59:41 2011
@@ -641,7 +641,7 @@
 
 CommandObjectBreakpointList::CommandOptions::CommandOptions() :
     Options (),
-    m_level (lldb::eDescriptionLevelFull)  // Breakpoint List defaults to brief descriptions
+    m_level (lldb::eDescriptionLevelBrief)  // Breakpoint List defaults to brief descriptions
 {
 }
 
@@ -708,7 +708,7 @@
 {
     Options::ResetOptionValues();
 
-    m_level = lldb::eDescriptionLevelFull;
+    m_level = lldb::eDescriptionLevelBrief;
     m_internal = false;
 }
 

Modified: lldb/trunk/test/alias_tests/TestAliases.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/alias_tests/TestAliases.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/alias_tests/TestAliases.py (original)
+++ lldb/trunk/test/alias_tests/TestAliases.py Fri Feb  4 16:59:41 2011
@@ -74,7 +74,7 @@
 
         self.runCmd ("bpa -p 1 -o 'print frame; print bp_loc'")
         self.runCmd ("bpa -c 2 -o 'frame variable b'")
-        self.expect ("bpi",
+        self.expect ("bpi -f",
                      substrs = [ "Current breakpoints:",
                                  "1: name = 'foo', locations = 1",
                                  "print frame; print bp_loc",

Modified: lldb/trunk/test/array_types/TestArrayTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/array_types/TestArrayTypes.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/array_types/TestArrayTypes.py (original)
+++ lldb/trunk/test/array_types/TestArrayTypes.py Fri Feb  4 16:59:41 2011
@@ -64,7 +64,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = ['resolved, hit count = 1'])
 
         # Issue 'variable list' command on several array-type variables.

Modified: lldb/trunk/test/bitfields/TestBitfields.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/bitfields/TestBitfields.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/bitfields/TestBitfields.py (original)
+++ lldb/trunk/test/bitfields/TestBitfields.py Fri Feb  4 16:59:41 2011
@@ -58,7 +58,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # This should display correctly.

Modified: lldb/trunk/test/breakpoint_command/TestBreakpointCommand.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/breakpoint_command/TestBreakpointCommand.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/breakpoint_command/TestBreakpointCommand.py (original)
+++ lldb/trunk/test/breakpoint_command/TestBreakpointCommand.py Fri Feb  4 16:59:41 2011
@@ -59,6 +59,10 @@
         # The breakpoint list now only contains breakpoint 1.
         self.expect("breakpoint list", "Breakpoints 1 & 2 created",
             substrs = ["1: file ='main.c', line = %d, locations = 1" % self.line,
+                       "2: file ='main.c', line = %d, locations = 1" % self.line] )
+
+        self.expect("breakpoint list -f", "Breakpoints 1 & 2 created",
+            substrs = ["1: file ='main.c', line = %d, locations = 1" % self.line,
                        "2: file ='main.c', line = %d, locations = 1" % self.line],
             patterns = ["1.1: .+at main.c:%d, .+unresolved, hit count = 0" % self.line,
                         "2.1: .+at main.c:%d, .+unresolved, hit count = 0" % self.line])
@@ -105,13 +109,13 @@
             startstr = "error: '2' is not a currently valid breakpoint id.")
 
         # The breakpoint list now only contains breakpoint 1.
-        self.expect("breakpoint list", "Breakpoint 1 exists",
+        self.expect("breakpoint list -f", "Breakpoint 1 exists",
             substrs = ["1: file ='main.c', line = %d, locations = 1, resolved = 1" %
                         self.line,
                        "hit count = 1"])
 
         # Not breakpoint 2.
-        self.expect("breakpoint list", "No more breakpoint 2", matching=False,
+        self.expect("breakpoint list -f", "No more breakpoint 2", matching=False,
             substrs = ["2: file ='main.c', line = %d, locations = 1, resolved = 1" %
                         self.line])
 
@@ -126,7 +130,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 2.
-        self.expect("breakpoint list", BREAKPOINT_HIT_TWICE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_TWICE,
             substrs = ['resolved, hit count = 2'])
 
     def breakpoint_command_script_parameters (self):

Modified: lldb/trunk/test/breakpoint_conditions/TestBreakpointConditions.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/breakpoint_conditions/TestBreakpointConditions.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/breakpoint_conditions/TestBreakpointConditions.py (original)
+++ lldb/trunk/test/breakpoint_conditions/TestBreakpointConditions.py Fri Feb  4 16:59:41 2011
@@ -67,7 +67,7 @@
             startstr = '(int) val = 3')
 
         # Also check the hit count, which should be 3, by design.
-        self.expect("breakpoint list", BREAKPOINT_HIT_THRICE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_THRICE,
             substrs = ["resolved = 1",
                        "Condition: val == 3",
                        "hit count = 3"])
@@ -83,7 +83,7 @@
         # created breakpoint, so that when the breakpoint hits, val == 1.
         self.runCmd("process kill")
         self.runCmd("breakpoint modify -c ''")
-        self.expect("breakpoint list", BREAKPOINT_STATE_CORRECT, matching=False,
+        self.expect("breakpoint list -f", BREAKPOINT_STATE_CORRECT, matching=False,
             substrs = ["Condition:"])
 
         # Now run the program again.

Modified: lldb/trunk/test/breakpoint_ignore_count/TestBreakpointIgnoreCount.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/breakpoint_ignore_count/TestBreakpointIgnoreCount.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/breakpoint_ignore_count/TestBreakpointIgnoreCount.py (original)
+++ lldb/trunk/test/breakpoint_ignore_count/TestBreakpointIgnoreCount.py Fri Feb  4 16:59:41 2011
@@ -63,7 +63,7 @@
             patterns = ['Process .* stopped'])
 
         # Also check the hit count, which should be 2, due to ignore count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_THRICE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_THRICE,
             substrs = ["resolved = 1",
                        "hit count = 2"])
 

Modified: lldb/trunk/test/breakpoint_locations/TestBreakpointLocations.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/breakpoint_locations/TestBreakpointLocations.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/breakpoint_locations/TestBreakpointLocations.py (original)
+++ lldb/trunk/test/breakpoint_locations/TestBreakpointLocations.py Fri Feb  4 16:59:41 2011
@@ -40,7 +40,7 @@
                         self.line)
 
         # The breakpoint list should show 3 locations.
-        self.expect("breakpoint list", "Breakpoint locations shown correctly",
+        self.expect("breakpoint list -f", "Breakpoint locations shown correctly",
             substrs = ["1: file ='main.c', line = %d, locations = 3" % self.line],
             patterns = ["where = a.out`func_inlined .+unresolved, hit count = 0",
                         "where = a.out`main .+\[inlined\].+unresolved, hit count = 0"])
@@ -85,7 +85,7 @@
             substrs = ["stop reason = breakpoint 1."])
 
         # At this point, 1.1 has a hit count of 0 and the other a hit count of 1".
-        self.expect("breakpoint list", "The breakpoints should report correct hit counts",
+        self.expect("breakpoint list -f", "The breakpoints should report correct hit counts",
             patterns = ["1\.1: .+ unresolved, hit count = 0 +Options: disabled",
                         "1\.2: .+ resolved, hit count = 1",
                         "1\.3: .+ resolved, hit count = 1"])

Modified: lldb/trunk/test/class_types/TestClassTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/class_types/TestClassTypes.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/class_types/TestClassTypes.py (original)
+++ lldb/trunk/test/class_types/TestClassTypes.py Fri Feb  4 16:59:41 2011
@@ -84,7 +84,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # We should be stopped on the ctor function of class C.
@@ -172,7 +172,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # Continue on inside the ctor() body...

Modified: lldb/trunk/test/dead-strip/TestDeadStrip.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/dead-strip/TestDeadStrip.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/dead-strip/TestDeadStrip.py (original)
+++ lldb/trunk/test/dead-strip/TestDeadStrip.py Fri Feb  4 16:59:41 2011
@@ -48,7 +48,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list 1", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f 1", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         self.runCmd("continue")
@@ -60,7 +60,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list 3", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f 3", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
 

Modified: lldb/trunk/test/enum_types/TestEnumTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/enum_types/TestEnumTypes.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/enum_types/TestEnumTypes.py (original)
+++ lldb/trunk/test/enum_types/TestEnumTypes.py Fri Feb  4 16:59:41 2011
@@ -47,7 +47,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # Look up information about the 'days' enum type.

Modified: lldb/trunk/test/forward/TestForwardDeclaration.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/forward/TestForwardDeclaration.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/forward/TestForwardDeclaration.py (original)
+++ lldb/trunk/test/forward/TestForwardDeclaration.py Fri Feb  4 16:59:41 2011
@@ -41,7 +41,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # This should display correctly.

Modified: lldb/trunk/test/function_types/TestFunctionTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/function_types/TestFunctionTypes.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/function_types/TestFunctionTypes.py (original)
+++ lldb/trunk/test/function_types/TestFunctionTypes.py Fri Feb  4 16:59:41 2011
@@ -45,7 +45,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # Check that the 'callback' variable display properly.

Modified: lldb/trunk/test/global_variables/TestGlobalVariables.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/global_variables/TestGlobalVariables.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/global_variables/TestGlobalVariables.py (original)
+++ lldb/trunk/test/global_variables/TestGlobalVariables.py Fri Feb  4 16:59:41 2011
@@ -45,7 +45,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # Check that GLOBAL scopes are indicated for the variables.

Modified: lldb/trunk/test/load_unload/TestLoadUnload.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/load_unload/TestLoadUnload.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/load_unload/TestLoadUnload.py (original)
+++ lldb/trunk/test/load_unload/TestLoadUnload.py Fri Feb  4 16:59:41 2011
@@ -184,7 +184,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # Issue the 'contnue' command.  We should stop agaian at a_function.
@@ -199,7 +199,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 2.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 2'])
 
 

Modified: lldb/trunk/test/set_values/TestSetValues.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/set_values/TestSetValues.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/set_values/TestSetValues.py (original)
+++ lldb/trunk/test/set_values/TestSetValues.py Fri Feb  4 16:59:41 2011
@@ -69,7 +69,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # main.c:15

Modified: lldb/trunk/test/signal/TestSendSignal.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/signal/TestSendSignal.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/signal/TestSendSignal.py (original)
+++ lldb/trunk/test/signal/TestSendSignal.py Fri Feb  4 16:59:41 2011
@@ -47,7 +47,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         self.runCmd("process status")

Modified: lldb/trunk/test/signed_types/TestSignedTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/signed_types/TestSignedTypes.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/signed_types/TestSignedTypes.py (original)
+++ lldb/trunk/test/signed_types/TestSignedTypes.py Fri Feb  4 16:59:41 2011
@@ -47,7 +47,7 @@
             substrs = ['state is stopped', 'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # Execute the assignment statement.

Modified: lldb/trunk/test/stl/TestSTL.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/stl/TestSTL.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/stl/TestSTL.py (original)
+++ lldb/trunk/test/stl/TestSTL.py Fri Feb  4 16:59:41 2011
@@ -56,7 +56,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # Now do 'thread step-in', we should stop on the basic_string template.

Modified: lldb/trunk/test/struct_types/TestStructTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/struct_types/TestStructTypes.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/struct_types/TestStructTypes.py (original)
+++ lldb/trunk/test/struct_types/TestStructTypes.py Fri Feb  4 16:59:41 2011
@@ -52,7 +52,7 @@
                        'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
 

Modified: lldb/trunk/test/unsigned_types/TestUnsignedTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/unsigned_types/TestUnsignedTypes.py?rev=124905&r1=124904&r2=124905&view=diff
==============================================================================
--- lldb/trunk/test/unsigned_types/TestUnsignedTypes.py (original)
+++ lldb/trunk/test/unsigned_types/TestUnsignedTypes.py Fri Feb  4 16:59:41 2011
@@ -47,7 +47,7 @@
             substrs = ['state is stopped', 'stop reason = breakpoint'])
 
         # The breakpoint should have a hit count of 1.
-        self.expect("breakpoint list", BREAKPOINT_HIT_ONCE,
+        self.expect("breakpoint list -f", BREAKPOINT_HIT_ONCE,
             substrs = [' resolved, hit count = 1'])
 
         # Test that unsigned types display correctly.





More information about the lldb-commits mailing list