[libcxx-commits] [libcxx] [libc++] added benchmarks for `string::append()` (PR #213990)

[Pavel Novikov via libcxx-commits]

================
@@ -43,6 +43,25 @@ void bench(std::string name, Func func, Mod modifier = {}) {
 #endif
 }
 
+template <typename Iterator>
----------------
toughengineer wrote:

> If you want I can ask you to add a benchmark for the other cases so that there is a direct need, but IMO that's silly.

A benchmark for other cases is clearly out of scope of this PR.

> OTOH that would have removed the need for this thread, which probably has taken longer by now than adding another benchmark that uses this facility. There is a tangible need of "we'll want to do it eventually and this is exactly what we'd do".

E.g. a filed issue calling to add a benchmark for other cases would be a reason enough to consider putting it in a separate header.
Otherwise it's unconvincing, sorry.

https://github.com/llvm/llvm-project/pull/213990