[libcxx-commits] [libcxx] [libc++] added benchmarks for `string::append()` (PR #213990)

[Nikolas Klauser via libcxx-commits]

================
@@ -43,6 +43,25 @@ void bench(std::string name, Func func, Mod modifier = {}) {
 #endif
 }
 
+template <typename Iterator>
----------------
philnik777 wrote:

> That's my point, since there is no need to use it now and there are no roadmap or plans in any tangible sense, there is no reason to put it in a header at this time, it can be factored out when the need arises.

Then we would never factor code out beforehand. libc++ doesn't have a roadmap, so everything is "we'll want to do this eventually". If you want I can ask you to add a benchmark for the other cases so that there is a direct need, but IMO that's silly. OTOH that would have removed the need for this thread, which probably has taken longer by now than adding another benchmark that uses this facility. There is a tangible need of "we'll want to do it eventually and this is exactly what we'd do".


https://github.com/llvm/llvm-project/pull/213990