[libcxx-commits] [libcxxabi] [libc++abi][test] Remove `XFAIL` in `cxa_thread_atexit_test.pass.cpp` (PR #232638)
via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Oct 16 00:58:16 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxxabi
Author: A. Jiang (frederick-vs-ja)
<details>
<summary>Changes</summary>
The multiple definition problem was fixed in cfe1b90e7cda8f2e801e23316c89e3800c5f363e so we should enable the test for LLVM libc now.
---
Full diff: https://github.com/llvm/llvm-project/pull/232638.diff
1 Files Affected:
- (modified) libcxxabi/test/cxa_thread_atexit_test.pass.cpp (-5)
``````````diff
diff --git a/libcxxabi/test/cxa_thread_atexit_test.pass.cpp b/libcxxabi/test/cxa_thread_atexit_test.pass.cpp
index c44afc2daf874c..d641591697b3c7 100644
--- a/libcxxabi/test/cxa_thread_atexit_test.pass.cpp
+++ b/libcxxabi/test/cxa_thread_atexit_test.pass.cpp
@@ -9,11 +9,6 @@
// UNSUPPORTED: no-threads
// REQUIRES: linux
-// __cxa_thread_atexit_impl is defined strongly in thread.cpp.o alongside
-// internal::call_atexit_callbacks, causing a multiple definition error when
-// statically linking against llvm-libc's libc.a.
-// XFAIL: LLVM-LIBC-FIXME
-
#include <assert.h>
#include <cxxabi.h>
``````````
</details>
https://github.com/llvm/llvm-project/pull/232638
More information about the libcxx-commits
mailing list