[libcxx-commits] [libcxxabi] [libc++abi][test] Remove `XFAIL` in `cxa_thread_atexit_test.pass.cpp` (PR #232638)
A. Jiang via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Oct 16 00:57:46 PDT 2026
https://github.com/frederick-vs-ja created https://github.com/llvm/llvm-project/pull/232638
The multiple definition problem was fixed in cfe1b90e7cda8f2e801e23316c89e3800c5f363e so we should enable the test for LLVM libc now.
>From bdad115115cc0ad9cdbee72719bf636bca18aa48 Mon Sep 17 00:00:00 2001
From: "A. Jiang" <de34 at live.cn>
Date: Fri, 16 Oct 2026 15:56:05 +0800
Subject: [PATCH] [libc++abi][test] Remove `XFAIL` in
`cxa_thread_atexit_test.pass.cpp`
The multiple definition problem was fixed in cfe1b90e7cda8f2e801e23316c89e3800c5f363e
so we should enable the test for LLVM libc now.
---
libcxxabi/test/cxa_thread_atexit_test.pass.cpp | 5 -----
1 file changed, 5 deletions(-)
diff --git a/libcxxabi/test/cxa_thread_atexit_test.pass.cpp b/libcxxabi/test/cxa_thread_atexit_test.pass.cpp
index c44afc2daf874c..d641591697b3c7 100644
--- a/libcxxabi/test/cxa_thread_atexit_test.pass.cpp
+++ b/libcxxabi/test/cxa_thread_atexit_test.pass.cpp
@@ -9,11 +9,6 @@
// UNSUPPORTED: no-threads
// REQUIRES: linux
-// __cxa_thread_atexit_impl is defined strongly in thread.cpp.o alongside
-// internal::call_atexit_callbacks, causing a multiple definition error when
-// statically linking against llvm-libc's libc.a.
-// XFAIL: LLVM-LIBC-FIXME
-
#include <assert.h>
#include <cxxabi.h>
More information about the libcxx-commits
mailing list