[libcxx-commits] [compiler-rt] [libcxx] [lldb] [libc++] Drop transitive includes by default (PR #195509)

[LLVM Continuous Integration via libcxx-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot2` while building `compiler-rt,libcxx,lldb` at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/31742

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
...
      |                                  ^~~~~~~~~~~~~~
/home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:50: error: expected expression
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                  ^
/home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:52: error: use of undeclared identifier 'pthread_mutex_t'
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                    ^~~~~~~~~~~~~~~
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
[3167/3282] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.x86_64.dir/asan_interceptors.cpp.o
FAILED: [code=1] compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.i386.o /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.i386.o 
cd /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.i386 && FLAGS=-m32 CLANG=/home/b/sanitizer-x86_64-linux/build/build_default/./bin/clang /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.i386.o
ninja: build stopped: subcommand failed.
FAILED: [code=1] runtimes/runtimes-stamps/runtimes-build /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-stamps/runtimes-build 
cd /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins && /usr/bin/cmake --build .
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild


@@@STEP_FAILURE@@@

@@@STEP_FAILURE@@@

@@@STEP_FAILURE@@@
@@@BUILD_STEP test compiler-rt symbolizer@@@
ninja: Entering directory `build_default'
[0/5] Performing build step for 'builtins'
ninja: no work to do.
[1/5] No install step for 'builtins'
[3/5] Completed 'builtins'
[3/5] Performing configure step for 'runtimes'
Not searching for unused variables given on the command line.
loading initial cache file /home/b/sanitizer-x86_64-linux/build/build_default/projects/runtimes/tmp/runtimes-cache-Release.cmake
-- Performing bootstrapping runtimes build.
-- Building with -fPIC
-- Precompiled headers enabled.
-- LLVM host triple: x86_64-unknown-linux-gnu
-- LLVM default target triple: x86_64-unknown-linux-gnu
-- Doxygen disabled.
-- Using libunwind testing configuration: /home/b/sanitizer-x86_64-linux/build/llvm-project/libunwind/test/configs/llvm-libunwind-shared.cfg.in
-- Failed to locate sphinx-build executable (missing: SPHINX_EXECUTABLE) 
-- Using libc++abi testing configuration: /home/b/sanitizer-x86_64-linux/build/llvm-project/libcxxabi/test/configs/llvm-libc++abi-shared.cfg.in
-- Using libc++ testing configuration: /home/b/sanitizer-x86_64-linux/build/llvm-project/libcxx/test/configs/llvm-libc++-shared.cfg.in
-- Clang-tidy tests are disabled since the Clang development package has no clangTidy target.
-- Compiler-RT supported architectures: x86_64;i386
-- Adding compiler-rt builtins test directory
-- Builtin supported architectures: i386;x86_64
-- Adding compiler-rt interception test directory
Step 8 (build compiler-rt symbolizer) failure: build compiler-rt symbolizer (failure)
...
      |                                  ^~~~~~~~~~~~~~
/home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:50: error: expected expression
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                  ^
/home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:52: error: use of undeclared identifier 'pthread_mutex_t'
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                    ^~~~~~~~~~~~~~~
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
[3167/3282] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.x86_64.dir/asan_interceptors.cpp.o
FAILED: [code=1] compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.i386.o /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.i386.o 
cd /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.i386 && FLAGS=-m32 CLANG=/home/b/sanitizer-x86_64-linux/build/build_default/./bin/clang /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.i386.o
ninja: build stopped: subcommand failed.
FAILED: [code=1] runtimes/runtimes-stamps/runtimes-build /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-stamps/runtimes-build 
cd /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins && /usr/bin/cmake --build .
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild




Step 9 (test compiler-rt symbolizer) failure: test compiler-rt symbolizer (failure)
...
      |                                  ^~~~~~~~~~~~~~
/home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:50: error: expected expression
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                  ^
/home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:52: error: use of undeclared identifier 'pthread_mutex_t'
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                    ^~~~~~~~~~~~~~~
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
[131/499] Generating Nsan-x86_64-Test
FAILED: [code=1] compiler-rt/lib/nsan/tests/Nsan-x86_64-Test /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/nsan/tests/Nsan-x86_64-Test 
cd /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/nsan/tests && /home/b/sanitizer-x86_64-linux/build/build_default/./bin/clang++ NsanTestObjects.NSanUnitTest.cpp.x86_64.o NsanTestObjects.nsan_unit_test_main.cpp.x86_64.o NsanTestObjects.gtest-all.cc.x86_64.o -o /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/nsan/tests/./Nsan-x86_64-Test -fuse-ld=lld -Wl,--color-diagnostics -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -resource-dir=/home/b/sanitizer-x86_64-linux/build/build_default/./lib/../lib/clang/23 -lstdc++ -fsanitize=numerical -m64
ld.lld: error: cannot open /home/b/sanitizer-x86_64-linux/build/build_default/./lib/../lib/clang/23/lib/x86_64-unknown-linux-gnu/libclang_rt.nsan.a: No such file or directory
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
FAILED: [code=1] compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.x86_64.o /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.x86_64.o 
cd /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.x86_64 && FLAGS=-m64 CLANG=/home/b/sanitizer-x86_64-linux/build/build_default/./bin/clang /home/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.x86_64.o
ninja: build stopped: subcommand failed.
FAILED: [code=1] runtimes/CMakeFiles/check-compiler-rt /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/CMakeFiles/check-compiler-rt 
cd /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins && /usr/bin/cmake --build /home/b/sanitizer-x86_64-linux/build/build_default/runtimes/runtimes-bins/ --target check-compiler-rt --config Release
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild





```

</details>

https://github.com/llvm/llvm-project/pull/195509