[libcxx-commits] [compiler-rt] [libcxx] [lldb] [libc++] Drop transitive includes by default (PR #195509)

[LLVM Continuous Integration via libcxx-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux` running on `sanitizer-buildbot7` while building `compiler-rt,libcxx,lldb` at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/37870

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
...
      |                                  ^~~~~~~~~~~~~~
/home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:50: error: expected expression
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                  ^
/home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:52: error: use of undeclared identifier 'pthread_mutex_t'
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                    ^~~~~~~~~~~~~~~
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
[2634/2694] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.aarch64.dir/asan_interceptors.cpp.o
FAILED: [code=1] compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64.o /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64.o 
cd /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64 && FLAGS=-march=armv8-a CLANG=/home/b/sanitizer-aarch64-linux/build/build_default/./bin/clang /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64.o
ninja: build stopped: subcommand failed.
FAILED: [code=1] runtimes/runtimes-stamps/runtimes-build /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-stamps/runtimes-build 
cd /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins && /usr/bin/cmake --build .
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild


@@@STEP_FAILURE@@@

@@@STEP_FAILURE@@@

@@@STEP_FAILURE@@@
@@@BUILD_STEP test compiler-rt symbolizer@@@
ninja: Entering directory `build_default'
[0/5] Performing build step for 'builtins'
ninja: no work to do.
[1/5] No install step for 'builtins'
[3/5] Completed 'builtins'
[3/5] Performing configure step for 'runtimes'
Not searching for unused variables given on the command line.
loading initial cache file /home/b/sanitizer-aarch64-linux/build/build_default/projects/runtimes/tmp/runtimes-cache-Release.cmake
-- Performing bootstrapping runtimes build.
-- Building with -fPIC
-- Precompiled headers enabled.
-- LLVM host triple: aarch64-unknown-linux-gnu
-- LLVM default target triple: aarch64-unknown-linux-gnu
-- Doxygen disabled.
-- Using libunwind testing configuration: /home/b/sanitizer-aarch64-linux/build/llvm-project/libunwind/test/configs/llvm-libunwind-shared.cfg.in
-- Failed to locate sphinx-build executable (missing: SPHINX_EXECUTABLE) 
-- Using libc++abi testing configuration: /home/b/sanitizer-aarch64-linux/build/llvm-project/libcxxabi/test/configs/llvm-libc++abi-shared.cfg.in
-- Using libc++ testing configuration: /home/b/sanitizer-aarch64-linux/build/llvm-project/libcxx/test/configs/llvm-libc++-shared.cfg.in
-- Clang-tidy tests are disabled since the Clang development package has no clangTidy target.
-- ABI list file not generated for configuration aarch64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.nonew, `check-cxx-abilist` will not be available.
-- Compiler-RT supported architectures: aarch64
-- Adding compiler-rt builtins test directory
-- Builtin supported architectures: aarch64
Step 8 (build compiler-rt symbolizer) failure: build compiler-rt symbolizer (failure)
...
      |                                  ^~~~~~~~~~~~~~
/home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:50: error: expected expression
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                  ^
/home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:52: error: use of undeclared identifier 'pthread_mutex_t'
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                    ^~~~~~~~~~~~~~~
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
[2634/2694] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.aarch64.dir/asan_interceptors.cpp.o
FAILED: [code=1] compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64.o /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64.o 
cd /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64 && FLAGS=-march=armv8-a CLANG=/home/b/sanitizer-aarch64-linux/build/build_default/./bin/clang /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64.o
ninja: build stopped: subcommand failed.
FAILED: [code=1] runtimes/runtimes-stamps/runtimes-build /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-stamps/runtimes-build 
cd /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins && /usr/bin/cmake --build .
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild




Step 9 (test compiler-rt symbolizer) failure: test compiler-rt symbolizer (failure)
...
      |                                  ^~~~~~~~~~~~~~
/home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:50: error: expected expression
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                  ^
/home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/sanitizer_wrappers.cpp:170:52: error: use of undeclared identifier 'pthread_mutex_t'
  170 |                              int(pthread_cond_t *, pthread_mutex_t *))
      |                                                    ^~~~~~~~~~~~~~~
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
[61/247] Generating RtsanTestObjects.rtsan_test_functional.cpp.aarch64.o
FAILED: [code=1] compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64.o /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64.o 
cd /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64 && FLAGS=-march=armv8-a CLANG=/home/b/sanitizer-aarch64-linux/build/build_default/./bin/clang /home/b/sanitizer-aarch64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/symbolizer/RTSanitizerCommonSymbolizerInternal.aarch64.o
[63/247] Generating ScudoUnitTestsObjects.primary_test.cpp.aarch64.o
[64/247] Generating RtsanTestObjects_FileOffset64.gmock-all.cc.aarch64.o
[65/247] Generating RtsanTestObjects.gmock-all.cc.aarch64.o
[66/247] Generating ScudoUnitTestsObjects.gtest-all.cc.aarch64.o
[67/247] Generating ScudoUnitTestsObjects.combined_test.cpp.aarch64.o
[68/247] Generating RtsanTestObjects_FileOffset64.gtest-all.cc.aarch64.o
[69/247] Generating RtsanTestObjects.gtest-all.cc.aarch64.o
[70/247] Generating RtsanTestObjects.rtsan_test_interceptors_posix.cpp.aarch64.o
[71/247] Generating RtsanTestObjects_FileOffset64.rtsan_test_interceptors_posix.cpp.aarch64.o
ninja: build stopped: subcommand failed.
FAILED: [code=1] runtimes/CMakeFiles/check-compiler-rt /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/CMakeFiles/check-compiler-rt 
cd /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins && /usr/bin/cmake --build /home/b/sanitizer-aarch64-linux/build/build_default/runtimes/runtimes-bins/ --target check-compiler-rt --config Release
ninja: build stopped: subcommand failed.

How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild





```

</details>

https://github.com/llvm/llvm-project/pull/195509