[libcxx-commits] [libcxx] [libc++] added benchmarks for `string::append()` (PR #213990)

[Pavel Novikov via libcxx-commits]

================
@@ -43,6 +43,25 @@ void bench(std::string name, Func func, Mod modifier = {}) {
 #endif
 }
 
+template <typename Iterator>
----------------
toughengineer wrote:

> Are you confused by me saying "a general utility"? I simply meant that we want to move the class into a header and not keep it directly in the `.bench.cpp`. I didn't mean that the class itself needs to be modified.

I'm not confused by you suggesting to move `unoptimizable_forward_iterator` into a header.
Considering that implication I asked

> Where else does it need to be used now?

here https://github.com/llvm/llvm-project/pull/213990#discussion_r3734501634.

Are you aware of concrete or at least tentative plans to use it elsewhere? Probably in benchmark code that is.

https://github.com/llvm/llvm-project/pull/213990