[libcxx-commits] [libcxx] [libc++] added benchmarks for `string::append()` (PR #213990)

[Pavel Novikov via libcxx-commits]

================
@@ -43,6 +43,25 @@ void bench(std::string name, Func func, Mod modifier = {}) {
 #endif
 }
 
+template <typename Iterator>
----------------
toughengineer wrote:

> I don't know what you want me to tell you. "something similar to this patch" isn't exactly hard to understand by most people. "a follow-up patch similar to this one" would be another way to phrase it.

I understand that by "something similar" you refer to the implementation of `unoptimizable_forward_iterator` in this PR, not the entire set of changes that also includes benchmarks for `std::string` append operation, which obviously should not be available as a general utility.

I don't understand what's exactly that "something" that you have in mind and in what way it should be "similar" to `unoptimizable_forward_iterator`.

> http://eel.is/c++draft/vector#lib:vector,constructor___ - but you could also just open your browser and do a tiny bit of work next time.

I understand that you probably have in mind some kind of benchmarks for other containers, not the implementation of e.g. `std::vector` ctor.

I asked you for examples of places in benchmark code where you want to use something and what you want to achieve there.

Unfortunately I don't see how opening my browser and doing work allows me to read other's minds, sorry.

https://github.com/llvm/llvm-project/pull/213990