[libcxx-commits] [libcxx] [libc++] Check zdump availability through executor (PR #216476)

[via libcxx-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Yihan Wang (yronglin)

<details>
<summary>Changes</summary>

Lit found `zdump` in the host environment, but the clean test executor could not, causing `std::system("zdump ...")` to fail.

The `%{exec}` runs the probe through the same executor environment used by the test.

---
Full diff: https://github.com/llvm/llvm-project/pull/216476.diff


1 Files Affected:

- (modified) libcxx/utils/libcxx/test/features/misc.py (+1-1) 


``````````diff
diff --git a/libcxx/utils/libcxx/test/features/misc.py b/libcxx/utils/libcxx/test/features/misc.py
index 1f4b808e40820..655a32f51d18a 100644
--- a/libcxx/utils/libcxx/test/features/misc.py
+++ b/libcxx/utils/libcxx/test/features/misc.py
@@ -242,7 +242,7 @@ def _mingwSupportsModules(cfg):
     # output generated by <chrono>'s time zone support.
     Feature(
         name="has-no-zdump",
-        when=lambda cfg: runScriptExitCode(cfg, ["zdump --version"]) != 0,
+        when=lambda cfg: runScriptExitCode(cfg, ["%{exec} zdump --version"]) != 0,
     ),
     Feature(
         name="can-create-symlinks",

``````````

</details>


https://github.com/llvm/llvm-project/pull/216476