[libcxx-commits] [libcxx] [libc++] Check zdump availability through executor (PR #216476)

Yihan Wang via libcxx-commits libcxx-commits at lists.llvm.org
Sat Aug 15 02:45:49 PDT 2026


https://github.com/yronglin created https://github.com/llvm/llvm-project/pull/216476

Lit found `zdump` in the host environment, but the clean test executor could not, causing `std::system("zdump ...")` to fail.

The `%{exec}` runs the probe through the same executor environment used by the test.

>From 3cd4e9385d26646e7837f151f1481c9e725f116b Mon Sep 17 00:00:00 2001
From: yronglin <yronglin777 at gmail.com>
Date: Sat, 15 Aug 2026 02:40:00 -0700
Subject: [PATCH] [libc++] Check zdump availability through executor

Signed-off-by: yronglin <yronglin777 at gmail.com>
---
 libcxx/utils/libcxx/test/features/misc.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/utils/libcxx/test/features/misc.py b/libcxx/utils/libcxx/test/features/misc.py
index 1f4b808e40820..655a32f51d18a 100644
--- a/libcxx/utils/libcxx/test/features/misc.py
+++ b/libcxx/utils/libcxx/test/features/misc.py
@@ -242,7 +242,7 @@ def _mingwSupportsModules(cfg):
     # output generated by <chrono>'s time zone support.
     Feature(
         name="has-no-zdump",
-        when=lambda cfg: runScriptExitCode(cfg, ["zdump --version"]) != 0,
+        when=lambda cfg: runScriptExitCode(cfg, ["%{exec} zdump --version"]) != 0,
     ),
     Feature(
         name="can-create-symlinks",



More information about the libcxx-commits mailing list