[libcxx-commits] [libcxx] [libc++] Disable -Werror when running historical benchmarks (PR #214761)

[via libcxx-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

<details>
<summary>Changes</summary>

Older versions of the library trigger warnigns that were introduced in newer versions of Clang. That's expected, and building with -Werror simply causes the test suite to fail when it would run fine, with warnings.

---
Full diff: https://github.com/llvm/llvm-project/pull/214761.diff


1 Files Affected:

- (modified) libcxx/utils/ci/lnt/run-benchmarks (+1) 


``````````diff
diff --git a/libcxx/utils/ci/lnt/run-benchmarks b/libcxx/utils/ci/lnt/run-benchmarks
index 6b454571617b8..a8111d331441e 100755
--- a/libcxx/utils/ci/lnt/run-benchmarks
+++ b/libcxx/utils/ci/lnt/run-benchmarks
@@ -171,6 +171,7 @@ def main(argv):
                             '--param', f'compiler={args.compiler}',
                             '--param', 'optimization=speed',
                             '--param', 'std=c++26',
+                            '--param', 'enable_werror=False', # older versions of the library trigger new warnings, don't fail
                             artifacts / 'benchmarks/libcxx/test/benchmarks']
         if args.spec_dir is not None:
             cmd += ['--param', f'spec_dir={args.spec_dir}']

``````````

</details>


https://github.com/llvm/llvm-project/pull/214761