[libcxx-commits] [libcxx] [libc++] Disable -Werror when running historical benchmarks (PR #214761)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 7 07:39:08 PDT 2026


https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/214761

Older versions of the library trigger warnigns that were introduced in newer versions of Clang. That's expected, and building with -Werror simply causes the test suite to fail when it would run fine, with warnings.

>From 92f0aa73ca670b15bc6ff92dcb86df3d7e473aa0 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Fri, 7 Aug 2026 10:36:58 -0400
Subject: [PATCH] [libc++] Disable -Werror when running historical benchmarks

Older versions of the library trigger warnigns that were introduced
in newer versions of Clang. That's expected, and building with -Werror
simply causes the test suite to fail when it would run fine, with warnings.
---
 libcxx/utils/ci/lnt/run-benchmarks | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libcxx/utils/ci/lnt/run-benchmarks b/libcxx/utils/ci/lnt/run-benchmarks
index 6b454571617b8..a8111d331441e 100755
--- a/libcxx/utils/ci/lnt/run-benchmarks
+++ b/libcxx/utils/ci/lnt/run-benchmarks
@@ -171,6 +171,7 @@ def main(argv):
                             '--param', f'compiler={args.compiler}',
                             '--param', 'optimization=speed',
                             '--param', 'std=c++26',
+                            '--param', 'enable_werror=False', # older versions of the library trigger new warnings, don't fail
                             artifacts / 'benchmarks/libcxx/test/benchmarks']
         if args.spec_dir is not None:
             cmd += ['--param', f'spec_dir={args.spec_dir}']



More information about the libcxx-commits mailing list