[libcxx-commits] [libcxx] [libc++] Fix the enable_warnings=True|False Lit parameter (PR #214113)
via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Aug 4 18:49:35 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r origin/main...HEAD libcxx/utils/libcxx/test/params.py
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- params.py 2026-08-05 01:46:51.000000 +0000
+++ params.py 2026-08-05 01:48:58.229421 +0000
@@ -22,22 +22,20 @@
"-Wctad-maybe-unsupported",
"-Wextra",
"-Wshadow",
"-Wundef",
"-Wunused-template",
- '-Wdeprecated-copy',
- '-Wdeprecated-copy-dtor',
+ "-Wdeprecated-copy",
+ "-Wdeprecated-copy-dtor",
"-Wshift-negative-value",
-
# These warnings should be enabled in order to support the MSVC
# team using the test suite; They enable the warnings below and
# expect the test suite to be clean.
"-Wsign-compare",
"-Wunused-variable",
"-Wunused-parameter",
"-Wunreachable-code",
-
# Technically not a warning flag, but might as well be:
"-flax-vector-conversions=none",
]
# Warnings that we always disable when running the test suite. Some of these are warnings that
@@ -48,44 +46,38 @@
_silencedWarningFlags = [
# Some of the flags we use are not used by every compilation step of the test suite. In
# particular, we validate flags added to %{link_flags} (such as -lc++experimental) by
# trying them out with a compile-only command, which warns that they are unused.
"-Wno-unused-command-line-argument",
-
"-Wno-attributes",
"-Wno-pessimizing-move",
"-Wno-noexcept-type",
"-Wno-aligned-allocation-unavailable",
"-Wno-atomic-alignment",
"-Wno-reserved-module-identifier",
-
# GCC warns about places where we might want to add sized allocation/deallocation
# functions, but we know better what we're doing/testing in the test suite.
"-Wno-sized-deallocation",
-
# Turn off warnings about user-defined literals with reserved suffixes. Those are
# just noise since we are testing the Standard Library itself.
"-Wno-literal-suffix", # GCC
"-Wno-user-defined-literals", # Clang
-
# GCC warns about this when TEST_IS_CONSTANT_EVALUATED is used on a non-constexpr
# function. (This mostly happens in C++11 mode.)
# TODO(mordante) investigate a solution for this issue.
"-Wno-tautological-compare",
# -Wstringop-overread and -Wstringop-overflow seem to be a bit buggy currently
"-Wno-stringop-overread",
"-Wno-stringop-overflow",
-
"-Wno-unused-local-typedef",
# Disable warnings for extensions used in C++03
"-Wno-local-type-template-args",
"-Wno-c++11-extensions",
# TODO(philnik) This fails with the PSTL.
"-Wno-unknown-pragmas",
-
# Don't fail compilation in case the compiler fails to perform the requested
# loop vectorization.
"-Wno-pass-failed",
# TODO: Find out why GCC warns in lots of places (is this a problem with always_inline?)
``````````
</details>
https://github.com/llvm/llvm-project/pull/214113
More information about the libcxx-commits
mailing list