[libcxx-commits] [libcxx] [libc++] Don't run multithreaded stringstream benchmarks (PR #158294)
via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Sep 12 06:50:35 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Louis Dionne (ldionne)
<details>
<summary>Changes</summary>
This results in invalid JSON output as reported
in google/benchmark#<!-- -->2039.
---
Full diff: https://github.com/llvm/llvm-project/pull/158294.diff
1 Files Affected:
- (modified) libcxx/test/benchmarks/stringstream.bench.cpp (+2-2)
``````````diff
diff --git a/libcxx/test/benchmarks/stringstream.bench.cpp b/libcxx/test/benchmarks/stringstream.bench.cpp
index b7c50a96ef51e..367024c49ac69 100644
--- a/libcxx/test/benchmarks/stringstream.bench.cpp
+++ b/libcxx/test/benchmarks/stringstream.bench.cpp
@@ -80,7 +80,7 @@ static void BM_Istream_numbers(benchmark::State& state) {
while (state.KeepRunning())
benchmark::DoNotOptimize(i += istream_numbers(sel.imbue));
}
-BENCHMARK(BM_Istream_numbers)->DenseRange(0, 3)->UseRealTime()->Threads(1)->ThreadPerCpu();
+BENCHMARK(BM_Istream_numbers)->DenseRange(0, 3);
static void BM_Ostream_number(benchmark::State& state) {
LocaleSelector sel(state);
@@ -92,6 +92,6 @@ static void BM_Ostream_number(benchmark::State& state) {
benchmark::DoNotOptimize(ss.str().c_str());
}
}
-BENCHMARK(BM_Ostream_number)->DenseRange(0, 3)->UseRealTime()->Threads(1)->ThreadPerCpu();
+BENCHMARK(BM_Ostream_number)->DenseRange(0, 3);
BENCHMARK_MAIN();
``````````
</details>
https://github.com/llvm/llvm-project/pull/158294
More information about the libcxx-commits
mailing list