[libcxx-commits] [libcxx] [libc++] Don't run multithreaded stringstream benchmarks (PR #158294)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Sep 12 06:50:03 PDT 2025
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/158294
This results in invalid JSON output as reported
in google/benchmark#2039.
>From d0b0317afe1090839de50a074f1946b1f7f9d471 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Fri, 12 Sep 2025 09:48:40 -0400
Subject: [PATCH] [libc++] Don't run multithreaded stringstream benchmarks
This results in invalid JSON output as reported
in google/benchmark#2039.
---
libcxx/test/benchmarks/stringstream.bench.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libcxx/test/benchmarks/stringstream.bench.cpp b/libcxx/test/benchmarks/stringstream.bench.cpp
index b7c50a96ef51e..367024c49ac69 100644
--- a/libcxx/test/benchmarks/stringstream.bench.cpp
+++ b/libcxx/test/benchmarks/stringstream.bench.cpp
@@ -80,7 +80,7 @@ static void BM_Istream_numbers(benchmark::State& state) {
while (state.KeepRunning())
benchmark::DoNotOptimize(i += istream_numbers(sel.imbue));
}
-BENCHMARK(BM_Istream_numbers)->DenseRange(0, 3)->UseRealTime()->Threads(1)->ThreadPerCpu();
+BENCHMARK(BM_Istream_numbers)->DenseRange(0, 3);
static void BM_Ostream_number(benchmark::State& state) {
LocaleSelector sel(state);
@@ -92,6 +92,6 @@ static void BM_Ostream_number(benchmark::State& state) {
benchmark::DoNotOptimize(ss.str().c_str());
}
}
-BENCHMARK(BM_Ostream_number)->DenseRange(0, 3)->UseRealTime()->Threads(1)->ThreadPerCpu();
+BENCHMARK(BM_Ostream_number)->DenseRange(0, 3);
BENCHMARK_MAIN();
More information about the libcxx-commits
mailing list