[libcxx-commits] [libcxx] [libc++] Don't mark lgamma_r as noexcept on Fuchsia (PR #157710)

Nico Weber via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 9 09:50:47 PDT 2025


https://github.com/nico created https://github.com/llvm/llvm-project/pull/157710

Building on Fuchsia is broken after #156547.
This disables the NOEXCEPT on Fuchsia to unbreak things. Hopefully we can come up with a more forward-compatible fix later.

>From 3343983cab91e958ea076c02e1ff0b0f973c0500 Mon Sep 17 00:00:00 2001
From: Nico Weber <thakis at chromium.org>
Date: Tue, 9 Sep 2025 12:49:13 -0400
Subject: [PATCH] [libc++] Don't mark lgamma_r as noexcept on Fuchsia

Building on Fuchsia is broken after #156547.
This disables the NOEXCEPT on Fuchsia to unbreak things.
Hopefully we can come up with a more forward-compatible fix later.
---
 libcxx/include/__random/binomial_distribution.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/include/__random/binomial_distribution.h b/libcxx/include/__random/binomial_distribution.h
index bada8cfdd74a3..816135216d970 100644
--- a/libcxx/include/__random/binomial_distribution.h
+++ b/libcxx/include/__random/binomial_distribution.h
@@ -104,7 +104,7 @@ class binomial_distribution {
 #  else
 #    define _LIBCPP_LGAMMA_R_NOEXCEPT
 #  endif
-#elif defined(__LLVM_LIBC__)
+#elif defined(__LLVM_LIBC__) && !defined(__Fuchsia__)
 #  define _LIBCPP_LGAMMA_R_NOEXCEPT _NOEXCEPT
 #else
 #  define _LIBCPP_LGAMMA_R_NOEXCEPT



More information about the libcxx-commits mailing list