[libcxx-commits] [libcxx] [libc++] Don't mark lgamma_r as noexcept on Fuchsia (PR #157710)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 9 09:51:21 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Nico Weber (nico)

<details>
<summary>Changes</summary>

Building on Fuchsia is broken after #<!-- -->156547.
This disables the NOEXCEPT on Fuchsia to unbreak things. Hopefully we can come up with a more forward-compatible fix later.

---
Full diff: https://github.com/llvm/llvm-project/pull/157710.diff


1 Files Affected:

- (modified) libcxx/include/__random/binomial_distribution.h (+1-1) 


``````````diff
diff --git a/libcxx/include/__random/binomial_distribution.h b/libcxx/include/__random/binomial_distribution.h
index bada8cfdd74a3..816135216d970 100644
--- a/libcxx/include/__random/binomial_distribution.h
+++ b/libcxx/include/__random/binomial_distribution.h
@@ -104,7 +104,7 @@ class binomial_distribution {
 #  else
 #    define _LIBCPP_LGAMMA_R_NOEXCEPT
 #  endif
-#elif defined(__LLVM_LIBC__)
+#elif defined(__LLVM_LIBC__) && !defined(__Fuchsia__)
 #  define _LIBCPP_LGAMMA_R_NOEXCEPT _NOEXCEPT
 #else
 #  define _LIBCPP_LGAMMA_R_NOEXCEPT

``````````

</details>


https://github.com/llvm/llvm-project/pull/157710


More information about the libcxx-commits mailing list