[libcxx-commits] [libcxx] libc++ test: update MinSequenceContainer.h to make some tests pass on MSVC STL (PR #140287)

[via libcxx-commits]

huixie90 wrote:

> > @AlexGuteniev I fixed my tests not relying on `MinSequenceContainer`
> 
> Thanks, but I don't think it is a path forward. The goal of my PR is to make the tests, including yours, pass with MSVC STL, so with your fix my PR does not make sense.
> 
> I think we should instead use preprocessor and make `insert_range` unavailable when `_LIBCPP_VERSION` is defined. This matches the practice of `LIBCPP_ASSERT` macro.

No I don't think you should guard against libc++. Your original fix looks good to me. the helper type in the test/std folder is meant to be used for all implementations. not just libc++. 

Anything that is libc++ specific is our extension and should be put into std/libcxx folder. and this is what I was doing in https://github.com/llvm/llvm-project/pull/140372


https://github.com/llvm/llvm-project/pull/140287