[libcxx-commits] [libcxx] libc++ test: update MinSequenceContainer.h to make some tests pass on MSVC STL (PR #140287)
Alex Guteniev via libcxx-commits
libcxx-commits at lists.llvm.org
Sat May 17 05:08:09 PDT 2025
AlexGuteniev wrote:
> @AlexGuteniev I fixed my tests not relying on `MinSequenceContainer`
Thanks, but I don't think it is a path forward. The goal of my PR is to make the tests, including yours, pass with MSVC STL, so with your fix my PR does not make sense.
I think we should instead use preprocessor and make `insert_range` unavailable when `_LIBCPP_VERSION` is defined. This matches the practice of `LIBCPP_ASSERT` macro.
https://github.com/llvm/llvm-project/pull/140287
More information about the libcxx-commits
mailing list