[libcxx-commits] [libcxx] [libc++] Disabled unexpected_disabled test in modules build (PR #144466)

[via libcxx-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Aiden Grossman (boomanaiden154)

<details>
<summary>Changes</summary>

This patch disables unexpected_disabled_cpp17.verify.cpp under clang modules builds because it changes diagnostics criteria post #<!-- -->143423, causing the test to fail.

This patch follows a similar style to
853059a15011fd8b57dd01b5189805fc8408e87f.

This was found when working on trying to land #<!-- -->144033.

---
Full diff: https://github.com/llvm/llvm-project/pull/144466.diff


1 Files Affected:

- (modified) libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp (+5) 


``````````diff
diff --git a/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp b/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
index 299cb123fbda3..b92f2baa02e47 100644
--- a/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
+++ b/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
@@ -8,6 +8,11 @@
 
 // UNSUPPORTED: c++03, c++11, c++14
 
+// When built with modules, this test gives diagnostics like declaration of
+// 'unexpected' must be imported from module 'std.expected.unexpected' before
+// it is required. Therefore disable it in this configuration.
+// UNSUPPORTED: clang-modules-build
+
 // test unexpected
 
 #include <exception>

``````````

</details>


https://github.com/llvm/llvm-project/pull/144466