[libcxx-commits] [libcxx] [libc++] Disabled unexpected_disabled test in modules build (PR #144466)

[Aiden Grossman via libcxx-commits]

https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/144466

This patch disables unexpected_disabled_cpp17.verify.cpp under clang modules builds because it changes diagnostics criteria post #143423, causing the test to fail.

This patch follows a similar style to
853059a15011fd8b57dd01b5189805fc8408e87f.

This was found when working on trying to land #144033.

>From 6bec009bd6189ee956f10cba4945ae95aa3edd88 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <agrossman154 at yahoo.com>
Date: Mon, 16 Jun 2025 21:52:11 -0700
Subject: [PATCH] [libc++] Disabled unexpected_disabled test in modules build

This patch disables unexpected_disabled_cpp17.verify.cpp under clang
modules builds because it changes diagnostics criteria post #143423,
causing the test to fail.

This patch follows a similar style to
853059a15011fd8b57dd01b5189805fc8408e87f.

This was found when working on trying to land #144033.
---
 .../unexpected_disabled_cpp17.verify.cpp                     | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp b/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
index 299cb123fbda3..b92f2baa02e47 100644
--- a/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
+++ b/libcxx/test/libcxx/depr/exception.unexpected/unexpected_disabled_cpp17.verify.cpp
@@ -8,6 +8,11 @@
 
 // UNSUPPORTED: c++03, c++11, c++14
 
+// When built with modules, this test gives diagnostics like declaration of
+// 'unexpected' must be imported from module 'std.expected.unexpected' before
+// it is required. Therefore disable it in this configuration.
+// UNSUPPORTED: clang-modules-build
+
 // test unexpected
 
 #include <exception>