[libcxx-commits] [libcxx] [libcxx][test] Fix a test for the range of file offsets on ARMv7 Linux targets. (PR #123449)

Vladimir Vereschaka via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jan 18 14:11:17 PST 2025


https://github.com/vvereschaka updated https://github.com/llvm/llvm-project/pull/123449

>From f8504783b68fa0c7af3f194206a320b834dfc4bd Mon Sep 17 00:00:00 2001
From: Vladimir Vereschaka <vvereschaka at accesssoftek.com>
Date: Fri, 17 Jan 2025 21:23:13 -0800
Subject: [PATCH 1/3] [libcxx][test] Fix a test for the range of file offsets
 on ARMv7 targets.

XFAIL offset_range test on the ARMv7 targets (32-bit).

Ref PR #122798
---
 .../fstreams/ifstream.members/offset_range.pass.cpp          | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
index 5afd4465db31e0..9bb52c8ac8f481 100644
--- a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
+++ b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
@@ -28,6 +28,11 @@
 //
 // XFAIL: target=powerpc-{{.+}}-aix{{.*}}
 
+// By default, off_t is typically a 32-bit integer on ARMv7 Linux systems, 
+// meaning it can represent file sizes up to 2GB (2^31 bytes) only.
+//
+// XFAIL: target=armv7{{.*}}-{{.+}}-linux{{.*}}
+
 #include <fstream>
 #include <iostream>
 #include <cassert>

>From 59b0b25c0e23cfa500784d24c04a3eff1ceaddee Mon Sep 17 00:00:00 2001
From: Vladimir Vereschaka <vvereschaka at accesssoftek.com>
Date: Fri, 17 Jan 2025 21:35:41 -0800
Subject: [PATCH 2/3] Fixed formatting

---
 .../fstreams/ifstream.members/offset_range.pass.cpp             | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
index 9bb52c8ac8f481..0563e760809756 100644
--- a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
+++ b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
@@ -28,7 +28,7 @@
 //
 // XFAIL: target=powerpc-{{.+}}-aix{{.*}}
 
-// By default, off_t is typically a 32-bit integer on ARMv7 Linux systems, 
+// By default, off_t is typically a 32-bit integer on ARMv7 Linux systems,
 // meaning it can represent file sizes up to 2GB (2^31 bytes) only.
 //
 // XFAIL: target=armv7{{.*}}-{{.+}}-linux{{.*}}

>From 3d17650f5016f96d8e3472e07de802ef39e1de58 Mon Sep 17 00:00:00 2001
From: Vladimir Vereschaka <vvereschaka at accesssoftek.com>
Date: Sat, 18 Jan 2025 14:10:59 -0800
Subject: [PATCH 3/3] Mark the test as UNSUPPORTED for the
 armv7-unknown-linux-gnueabihf target.

---
 .../fstreams/ifstream.members/offset_range.pass.cpp             | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
index 0563e760809756..6ffe750564c2c9 100644
--- a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
+++ b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
@@ -31,7 +31,7 @@
 // By default, off_t is typically a 32-bit integer on ARMv7 Linux systems,
 // meaning it can represent file sizes up to 2GB (2^31 bytes) only.
 //
-// XFAIL: target=armv7{{.*}}-{{.+}}-linux{{.*}}
+// UNSUPPORTED: target=armv7-unknown-linux-gnueabihf
 
 #include <fstream>
 #include <iostream>



More information about the libcxx-commits mailing list