[libcxx-commits] [libcxx] [libcxx][test] Fix a test for the range of file offsets on ARMv7 Linux targets. (PR #123449)

[Martin Storsjö via libcxx-commits]

================
@@ -28,6 +28,11 @@
 //
 // XFAIL: target=powerpc-{{.+}}-aix{{.*}}
 
+// By default, off_t is typically a 32-bit integer on ARMv7 Linux systems,
+// meaning it can represent file sizes up to 2GB (2^31 bytes) only.
+//
+// XFAIL: target=armv7{{.*}}-{{.+}}-linux{{.*}}
----------------
mstorsjo wrote:

This reasoning looks and sounds reasonable… however it doesn’t seem to hold universally, because we do have some existing CI test configurations that also run on armv7 Linux, where this test does pass. It didn’t trigger this XFAIL though, because the triple has a slightly different form - `target=armv7l-linux-gnueabihf`, so there’s no vendor field. If you’d tweak the regex to not require a vendor field, I think it would match - and this XFAIL would trigger…

Apparently that setup has got 64 bit `off_t` by default?

https://github.com/llvm/llvm-project/pull/123449