[libcxx-commits] [libcxx] [libc++] Disable _LIBCPP_NODEBUG temporarily (PR #122393)

[David Blaikie via libcxx-commits]

dwblaikie wrote:

> > (might've been best to revert the previous patch rather than create this urgency - and that'd still be an option to avoid shipping this regression)
> 
> As I explained in the other thread, this change touches a lot of things and reverting the original patch would have caused a bunch of conflicts.

I appreciate that it's a big patch & causes a lot of churn to commit/revert - though the number of failures, and the impact of disabling LIBCPP_NODEBUG entirely (substantial regressions in debug info size) seems enough to warrant a revert-to-green to me.

>  If it comes to that we could probably shuffle around and do it, but in my experience it's better to fix these things fast when they happen, otherwise we'll just carry this debt for the foreseeable future.

That doesn't seem like the best approach - sort of using this to force prioritizing a fix with urgency that is artificial. 

>  I don't know how many times we've been in the same situation and whenever we don't have a direct incentive to fix something, it just doesn't happen. So as of right now, I still feel like turning this off temporarily and trying to get the underlying issues fixed is the right approach, but we can reevaluate later if there are deep reasons why this is difficult to fix.

The direct incentive seems to be that we both/all want debug info size reductions. And the folks who care about that most are the folks who work on debug info emission, the ones most suited to fix the bugs... so it feels like incentives are aligned, without the need for this extra time pressure/standing regression/leverage in the project.

https://github.com/llvm/llvm-project/pull/122393