[libcxx-commits] [libcxx] [libc++] Disable _LIBCPP_NODEBUG temporarily (PR #122393)

[Louis Dionne via libcxx-commits]

ldionne wrote:

> (might've been best to revert the previous patch rather than create this urgency - and that'd still be an option to avoid shipping this regression)

As I explained in the other thread, this change touches a lot of things and reverting the original patch would have caused a bunch of conflicts. If it comes to that we could probably shuffle around and do it, but in my experience it's better to fix these things fast when they happen, otherwise we'll just carry this debt for the foreseeable future. I don't know how many times we've been in the same situation and whenever we don't have a direct incentive to fix something, it just doesn't happen. So as of right now, I still feel like turning this off temporarily and trying to get the underlying issues fixed is the right approach, but we can reevaluate later if there are deep reasons why this is difficult to fix.

https://github.com/llvm/llvm-project/pull/122393