[libcxx-commits] [libcxx] Revert "[libc++][test] extend -linux-gnu XFAIL to cover all of the -linux targets (#129140)" (PR #129271)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Feb 28 12:58:19 PST 2025
https://github.com/ldionne approved this pull request.
Test changes often have subtle implications and need to be looked at carefully. `XFAIL` and `UNSUPPORTED` is basically how we control what test coverage we have for the library, so it's actually very important to get right, lest it's possible to turn off coverage for whole parts of the library without intending to do so.
Thanks for reverting, please open a PR when you're ready to re-land and we can go over it to make sure it does what you intend it to do. It's also possible that we'll suggest a different approach since it seems you're trying to get coverage for a different flavour of Linux.
https://github.com/llvm/llvm-project/pull/129271
More information about the libcxx-commits
mailing list