[libcxx-commits] [libcxx] Revert "[libc++][test] extend -linux-gnu XFAIL to cover all of the -linux targets (#129140)" (PR #129271)
via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Feb 28 09:13:42 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Paul Osmialowski (pawosm-arm)
<details>
<summary>Changes</summary>
The effect of this commit is too broad and may affect also those variants of Linux systems on which the affected test cases are known to pass.
An alternative version of this commit will be prepared afresh.
This reverts commit c93dc581d979eb20ded470d2c16e51b3e775f6e7.
---
Full diff: https://github.com/llvm/llvm-project/pull/129271.diff
10 Files Affected:
- (modified) libcxx/test/std/input.output/iostream.format/std.manip/setfill_wchar_max.pass.cpp (+1-1)
- (modified) libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp (+1-1)
- (modified) libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp (+1-1)
- (modified) libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp (+1-1)
- (modified) libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp (+1-1)
- (modified) libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp (+1-1)
- (modified) libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp (+1-1)
- (modified) libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp (+1-1)
- (modified) libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp (+1-1)
- (modified) libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp (+1-1)
``````````diff
diff --git a/libcxx/test/std/input.output/iostream.format/std.manip/setfill_wchar_max.pass.cpp b/libcxx/test/std/input.output/iostream.format/std.manip/setfill_wchar_max.pass.cpp
index 82842a75827ac..9d4126153cc23 100644
--- a/libcxx/test/std/input.output/iostream.format/std.manip/setfill_wchar_max.pass.cpp
+++ b/libcxx/test/std/input.output/iostream.format/std.manip/setfill_wchar_max.pass.cpp
@@ -16,7 +16,7 @@
// XFAIL: target={{.*}}-windows{{.*}} && libcpp-abi-version=1
// XFAIL: target=armv{{7|8}}{{l?}}{{.*}}-linux-gnueabihf && libcpp-abi-version=1
-// XFAIL: target=aarch64{{.*}}-linux{{.*}} && libcpp-abi-version=1
+// XFAIL: target=aarch64{{.*}}-linux-gnu && libcpp-abi-version=1
#include <iomanip>
#include <ostream>
diff --git a/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp
index 879597b2f80fd..57b8c13aa3c14 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp
@@ -18,7 +18,7 @@
// TODO: investigation needed
// TODO(netbsd): incomplete support for locales
-// XFAIL: target={{.*}}-linux{{.*}}, netbsd, freebsd
+// XFAIL: target={{.*}}-linux-gnu{{.*}}, netbsd, freebsd
// REQUIRES: locale.cs_CZ.ISO8859-2
#include <regex>
diff --git a/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp
index 59fb1c48e15d3..430d35fe739e5 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp
@@ -22,7 +22,7 @@
// regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
-// XFAIL: target={{.*}}-linux{{.*}}, freebsd
+// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp
index 0a966759eac3b..b512fa9b5fcf8 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp
@@ -22,7 +22,7 @@
// regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
-// XFAIL: target={{.*}}-linux{{.*}}, freebsd
+// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp
index 87ff1e5b6ef12..472dc19680263 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp
@@ -22,7 +22,7 @@
// regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
-// XFAIL: target={{.*}}-linux{{.*}}, freebsd
+// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp
index c4b211e613bec..9125df404b1de 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp
@@ -22,7 +22,7 @@
// regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
-// XFAIL: target={{.*}}-linux{{.*}}, freebsd
+// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp
index 56cf2e6a61ff3..f85b6a40ce129 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp
@@ -22,7 +22,7 @@
// regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
-// XFAIL: target={{.*}}-linux{{.*}}, freebsd
+// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp
index 4655a5c2e0ee6..aa9441cb3e58f 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp
@@ -22,7 +22,7 @@
// regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
-// XFAIL: target={{.*}}-linux{{.*}}, freebsd
+// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp
index 7bc8a537ca228..9746e45f29da5 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp
@@ -22,7 +22,7 @@
// regex_constants::match_flag_type flags = regex_constants::match_default);
// TODO: investigation needed
-// XFAIL: target={{.*}}-linux{{.*}}, freebsd
+// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp b/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp
index 3cbbaef9c81b5..178979d5b9ce8 100644
--- a/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp
+++ b/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp
@@ -23,7 +23,7 @@
// lookup_collatename(ForwardIterator first, ForwardIterator last) const;
// TODO: investigation needed
-// XFAIL: target={{.*}}-linux{{.*}}
+// XFAIL: target={{.*}}-linux-gnu{{.*}}
#include <regex>
#include <iterator>
``````````
</details>
https://github.com/llvm/llvm-project/pull/129271
More information about the libcxx-commits
mailing list