[libcxx-commits] [libcxx] [libc++][valarray] Applied `[[nodiscard]]` (PR #170996)

[A. Jiang via libcxx-commits]

frederick-vs-ja wrote:

> We already marked otherwise deprecated (and removed) functions as `[[nodiscard]]` as per review comments.

Hmm, I meant that these `std::begin`/`std::end` overloads will be probably removed in _all_ modes, not just C++26.

> In that case for consistency and because there is no harm, maybe we should keep the change, which is a NFC basically.

After thinking a while, I found that the future PR implementing P3016R6 should change `libcxx/test/libcxx/numerics/numarray/nodiscard.verify.cpp` again (to verify that member `begin`/`end` are marked `[[__nodiscard__]]`).

So now I think it should be fine enough to merge this PR as-is.

https://github.com/llvm/llvm-project/pull/170996