[libcxx-commits] [libcxx] [libc++][valarray] Applied `[[nodiscard]]` (PR #170996)

[Hristo Hristov via libcxx-commits]

H-G-Hristov wrote:

> I think `std::begin`/`std::end` overloads for `valarray` will be removed soon. See [P3016R6](https://wg21.link/p3016r6) which will be, IMO probably, applied as a DR to old modes. I'd like to avoid touching them at this moment.
> 
> Other changes LGTM.

I was about to commit the revert but let me ask again: We already marked otherwise deprecated methods as `[[nodiscard]]` as per review comments. In that case for consistency and because there is no harm, maybe we should keep the change, which is a NFC basically.

https://github.com/llvm/llvm-project/pull/170996