[libcxx-commits] [libcxx] [libc++][test] Use `ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings)` for `-Wno-psabi` (PR #113608)
via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Oct 24 11:42:32 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Stephan T. Lavavej (StephanTLavavej)
<details>
<summary>Changes</summary>
MSVC doesn't understand `-Wno-psabi`, which was introduced here by @<!-- -->ldionne in #<!-- -->106077.
Using `ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings)` (implemented by #<!-- -->75317) avoids passing this to MSVC.
---
Full diff: https://github.com/llvm/llvm-project/pull/113608.diff
1 Files Affected:
- (modified) libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp (+1-1)
``````````diff
diff --git a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
index 5130758d5efd52..abb12d6a3c2473 100644
--- a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
+++ b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
@@ -18,7 +18,7 @@
// Ignore diagnostic about vector types changing the ABI on some targets, since
// that is irrelevant for this test.
-// ADDITIONAL_COMPILE_FLAGS: -Wno-psabi
+// ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings): -Wno-psabi
#include <atomic>
#include <cassert>
``````````
</details>
https://github.com/llvm/llvm-project/pull/113608
More information about the libcxx-commits
mailing list