[libcxx-commits] [libcxx] [libc++][test] Use `ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings)` for `-Wno-psabi` (PR #113608)
Stephan T. Lavavej via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Oct 24 11:41:59 PDT 2024
https://github.com/StephanTLavavej created https://github.com/llvm/llvm-project/pull/113608
MSVC doesn't understand `-Wno-psabi`, which was introduced here by @ldionne in #106077.
Using `ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings)` (implemented by #75317) avoids passing this to MSVC.
>From 328dd52f9e18793fb822c5f7d233f0e2933712c1 Mon Sep 17 00:00:00 2001
From: "Stephan T. Lavavej" <stl at nuwen.net>
Date: Thu, 24 Oct 2024 11:36:08 -0700
Subject: [PATCH] Use `ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings)` for
`-Wno-psabi`.
---
.../std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
index 5130758d5efd52..abb12d6a3c2473 100644
--- a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
+++ b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
@@ -18,7 +18,7 @@
// Ignore diagnostic about vector types changing the ABI on some targets, since
// that is irrelevant for this test.
-// ADDITIONAL_COMPILE_FLAGS: -Wno-psabi
+// ADDITIONAL_COMPILE_FLAGS(gcc-style-warnings): -Wno-psabi
#include <atomic>
#include <cassert>
More information about the libcxx-commits
mailing list