[libcxx-commits] [libcxx] [libc++] Run the test suite with optimizations by default (PR #118006)

[Louis Dionne via libcxx-commits]

ldionne wrote:

> > > This significantly increases the time it takes to run the testsuite and might actually be detrimental to finding bugs, since the sanitizers tend to be less effective due to the optimizer removing UB in some cases. What is the benefit here?
> > 
> > 
> > The benefit is that we're testing what people actually ship in production. I'd be OK with not making it the default, but I think we should at least have a job that enables optimizations. For example, it looks like this breaks the CI as-is.
> 
> Shouldn't the `generic-optimized-speed` already do this?

I didn't remember that we already had that. That solves most of my concerns. If I had remembered that, I don't think I'd have created this patch.

https://github.com/llvm/llvm-project/pull/118006