[libcxx-commits] [libcxx] [libc++] Run the test suite with optimizations by default (PR #118006)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> > This significantly increases the time it takes to run the testsuite and might actually be detrimental to finding bugs, since the sanitizers tend to be less effective due to the optimizer removing UB in some cases. What is the benefit here?
> 
> The benefit is that we're testing what people actually ship in production. I'd be OK with not making it the default, but I think we should at least have a job that enables optimizations. For example, it looks like this breaks the CI as-is.

Shouldn't the `generic-optimized-speed` already do this? I'm not sure exactly what the failures are, but it looks like the C++03 ones are most likely unwarranted assumptions about `operator now` being always called (which I agree is a bug in the test suite) and GCC seems to have a bunch of false-positive warnings. This seems like a rather marginal yield for making the CI even slower. I'd be very happy with something like once a week we check all configurations with optimizations enabled if you think it'd be worth the effort to set this up.

https://github.com/llvm/llvm-project/pull/118006