[libcxx-commits] [libcxx] [libc++][CI] Updates the documentation. (PR #85264)

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 16 07:04:43 PDT 2024


https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/85264

>From b1dca7a79c378eb7c9ec485c910e98689d178890 Mon Sep 17 00:00:00 2001
From: Mark de Wever <koraq at xs4all.nl>
Date: Thu, 14 Mar 2024 17:55:57 +0100
Subject: [PATCH 1/2] [libc++][CI] Updates the documentation.

The documentation mentions manually pushing Docker images to the CI. The
preferred way is to use the proper GitHub action. This updates the
documentation.
---
 libcxx/utils/ci/Dockerfile | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/libcxx/utils/ci/Dockerfile b/libcxx/utils/ci/Dockerfile
index 178cba41593388..2dca0282e44391 100644
--- a/libcxx/utils/ci/Dockerfile
+++ b/libcxx/utils/ci/Dockerfile
@@ -7,15 +7,13 @@
 #===----------------------------------------------------------------------===##
 #
 # This file defines the buildkite and github actions builder images.
-# You can build & push both images using:
+# You can build both images using:
 #
 #   docker compose build
-#   docker compose push
 #
-# Or you can select a single image to build & push using:
+# Or you can select a single image to build
 #
 #  docker compose build buildkite-builder
-#  docker compose push buildkite-builder
 #
 # The final images can be found at
 #
@@ -23,7 +21,8 @@
 #  ghcr.io/libcxx/actions-builder
 #  ghcr.io/libcxx/android-buildkite-builder
 #
-# Members of the github.com/libcxx/ organizations have permissions required to push new images.
+# Members of the github.com/libcxx/ organizations can push new images to the CI
+# This is done by GitHub actions in the https://github.com/libcxx/builders repo.
 #
 # ===----------------------------------------------------------------------===##
 #                     Running the buildkite image

>From 94efaf1231c21a4ed0c33ac1580483b7b6f4bce3 Mon Sep 17 00:00:00 2001
From: Mark de Wever <zar-rpg at xs4all.nl>
Date: Sat, 16 Mar 2024 15:04:36 +0100
Subject: [PATCH 2/2] Update libcxx/utils/ci/Dockerfile

Co-authored-by: Will Hawkins <whh8b at obs.cr>
---
 libcxx/utils/ci/Dockerfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/utils/ci/Dockerfile b/libcxx/utils/ci/Dockerfile
index 2dca0282e44391..db88da20b977a8 100644
--- a/libcxx/utils/ci/Dockerfile
+++ b/libcxx/utils/ci/Dockerfile
@@ -21,7 +21,7 @@
 #  ghcr.io/libcxx/actions-builder
 #  ghcr.io/libcxx/android-buildkite-builder
 #
-# Members of the github.com/libcxx/ organizations can push new images to the CI
+# Members of the github.com/libcxx/ organizations can push new images to the CI.
 # This is done by GitHub actions in the https://github.com/libcxx/builders repo.
 #
 # ===----------------------------------------------------------------------===##



More information about the libcxx-commits mailing list