[libcxx-commits] [libcxx] [libc++][CI] Updates the documentation. (PR #85264)

via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 14 09:59:01 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

<details>
<summary>Changes</summary>

The documentation mentions manually pushing Docker images to the CI. The preferred way is to use the proper GitHub action. This updates the documentation.

---
Full diff: https://github.com/llvm/llvm-project/pull/85264.diff


1 Files Affected:

- (modified) libcxx/utils/ci/Dockerfile (+4-5) 


``````````diff
diff --git a/libcxx/utils/ci/Dockerfile b/libcxx/utils/ci/Dockerfile
index 178cba41593388..2dca0282e44391 100644
--- a/libcxx/utils/ci/Dockerfile
+++ b/libcxx/utils/ci/Dockerfile
@@ -7,15 +7,13 @@
 #===----------------------------------------------------------------------===##
 #
 # This file defines the buildkite and github actions builder images.
-# You can build & push both images using:
+# You can build both images using:
 #
 #   docker compose build
-#   docker compose push
 #
-# Or you can select a single image to build & push using:
+# Or you can select a single image to build
 #
 #  docker compose build buildkite-builder
-#  docker compose push buildkite-builder
 #
 # The final images can be found at
 #
@@ -23,7 +21,8 @@
 #  ghcr.io/libcxx/actions-builder
 #  ghcr.io/libcxx/android-buildkite-builder
 #
-# Members of the github.com/libcxx/ organizations have permissions required to push new images.
+# Members of the github.com/libcxx/ organizations can push new images to the CI
+# This is done by GitHub actions in the https://github.com/libcxx/builders repo.
 #
 # ===----------------------------------------------------------------------===##
 #                     Running the buildkite image

``````````

</details>


https://github.com/llvm/llvm-project/pull/85264


More information about the libcxx-commits mailing list