[libcxx-commits] [libcxx] [libc++] Specialize unique_ptr for the default deleter (PR #96504)
via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jun 25 03:09:51 PDT 2024
zmodem wrote:
> @zmodem Thanks for the info. Would you be able to also provide numbers for #76756? Something in the release notes like "this change resulted in a 5% decrease in debug info size for Chromium" always sounds great.
Sure! Compared to libc++ head, applying that:
- Total .obj file size reduced 5.5%
- chrome.dll.pdb size reduced 5.1%
- The type information size in the PDB reduced 10.6%
Those are very appealing numbers for us :)
These are my local build time measurements:
With head:
```
real 37m23.793s
user 4121m5.728s
sys 408m9.989s
```
With my patch:
```
real 36m47.368s
user 4051m46.384s
sys 401m42.658s
```
With #76756:
```
real 36m4.842s
user 3970m57.689s
sys 398m46.022s
```
Even if these measurements are not scientific, the numbers point in the right direction.
>
> I hope it's good enough if #76756 lands in ~2 months?
Yes, that's good for us.
> It would also be great if you could run the patch through its paces within google.
I've asked folks more familiar with the internal processes to take a look.
https://github.com/llvm/llvm-project/pull/96504
More information about the libcxx-commits
mailing list