[libcxx-commits] [libcxx] [libc++] Specialize unique_ptr for the default deleter (PR #96504)
Michael Buch via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jun 25 01:03:50 PDT 2024
Michael137 wrote:
> @Michael137 Thanks for all the work on this! I'm pretty sure this whole effort will drastically improve the QoI and maintainability of libc++. BTW sorry for being responsible for a significant amount of the additional complexity due to changed layouts in the pretty printers. Do you have any plans to remove support for old versions of the layouts at any point?
No problem! The way the pretty-printers are written makes them susceptible to these kinds of changes. We'll probably maintain both layouts for some time, but we already do that for other types like `std::string` too. With some refactoring I don't think it's going to be a big problem. (side-note, a nice benefit from the new simpler layout is that we'll be able to avoid bugs like https://github.com/llvm/llvm-project/issues/68396#issuecomment-1752092231).
https://github.com/llvm/llvm-project/pull/96504
More information about the libcxx-commits
mailing list