[libcxx-commits] [libcxx] [libc++] Adjust XFAIL for quick_exit (PR #94274)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jun 4 07:00:50 PDT 2024
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/94274
>From 04bb83ab978f764beddf04c9e0bb705ced7ca3a2 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Mon, 3 Jun 2024 15:32:04 -0400
Subject: [PATCH 1/2] [libc++] Adjust XFAIL for quick_exit
This avoids making the assumption that quick_exit will never be implemented
on macOS.
---
.../support.start.term/quick_exit.pass.cpp | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp b/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp
index 5a70ea5bd570b..12a41093df843 100644
--- a/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp
+++ b/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp
@@ -8,11 +8,12 @@
// UNSUPPORTED: c++03
-// ::quick_exit and ::at_quick_exit are not implemented on macOS.
+// ::quick_exit and ::at_quick_exit were not implemented in older versions of macOS
// TODO: We should never be using `darwin` as the triple, but LLVM's config.guess script
// guesses the host triple to be darwin instead of macosx when on macOS.
-// XFAIL: target={{.+}}-apple-macos{{.*}}
-// XFAIL: target={{.+}}-apple-darwin{{.+}}
+// XFAIL: target={{.+}}-apple-macos10.{{13|14|15}}
+// XFAIL: target={{.+}}-apple-macos{{11|12|13|14}}{{(.+)?}}
+// XFAIL: target={{.+}}-apple-darwin{{17|18|19|20|21|22|23}}{{(.+)?}}
// test quick_exit and at_quick_exit
>From 8f2173cc05ff3b8a0df562474cd6d130d7167b8b Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Tue, 4 Jun 2024 10:00:38 -0400
Subject: [PATCH 2/2] Fix typo in target triple for macOS
---
.../language.support/support.start.term/quick_exit.pass.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp b/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp
index 12a41093df843..d8eff69cb53fe 100644
--- a/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp
+++ b/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp
@@ -11,8 +11,8 @@
// ::quick_exit and ::at_quick_exit were not implemented in older versions of macOS
// TODO: We should never be using `darwin` as the triple, but LLVM's config.guess script
// guesses the host triple to be darwin instead of macosx when on macOS.
-// XFAIL: target={{.+}}-apple-macos10.{{13|14|15}}
-// XFAIL: target={{.+}}-apple-macos{{11|12|13|14}}{{(.+)?}}
+// XFAIL: target={{.+}}-apple-macosx10.{{13|14|15}}
+// XFAIL: target={{.+}}-apple-macosx{{11|12|13|14}}{{(.+)?}}
// XFAIL: target={{.+}}-apple-darwin{{17|18|19|20|21|22|23}}{{(.+)?}}
// test quick_exit and at_quick_exit
More information about the libcxx-commits
mailing list