[libcxx-commits] [libcxx] [libc++] Adjust XFAIL for quick_exit (PR #94274)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jun 3 12:34:51 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

<details>
<summary>Changes</summary>

This avoids making the assumption that quick_exit will never be implemented on macOS.

---
Full diff: https://github.com/llvm/llvm-project/pull/94274.diff


1 Files Affected:

- (modified) libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp (+4-3) 


``````````diff
diff --git a/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp b/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp
index 5a70ea5bd570b..12a41093df843 100644
--- a/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp
+++ b/libcxx/test/std/language.support/support.start.term/quick_exit.pass.cpp
@@ -8,11 +8,12 @@
 
 // UNSUPPORTED: c++03
 
-// ::quick_exit and ::at_quick_exit are not implemented on macOS.
+// ::quick_exit and ::at_quick_exit were not implemented in older versions of macOS
 // TODO: We should never be using `darwin` as the triple, but LLVM's config.guess script
 //       guesses the host triple to be darwin instead of macosx when on macOS.
-// XFAIL: target={{.+}}-apple-macos{{.*}}
-// XFAIL: target={{.+}}-apple-darwin{{.+}}
+// XFAIL: target={{.+}}-apple-macos10.{{13|14|15}}
+// XFAIL: target={{.+}}-apple-macos{{11|12|13|14}}{{(.+)?}}
+// XFAIL: target={{.+}}-apple-darwin{{17|18|19|20|21|22|23}}{{(.+)?}}
 
 // test quick_exit and at_quick_exit
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/94274


More information about the libcxx-commits mailing list