[libcxx-commits] [libcxx] Remove unnecessary _LIBCPP_STRING_INTERNAL_MEMORY_ACCESS (PR #79574)

via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 26 02:44:01 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Tacet (AdvenamTacet)

<details>
<summary>Changes</summary>

This macro is unnsecessary with `basic_string& operator=(value_type __c)`.

---
Full diff: https://github.com/llvm/llvm-project/pull/79574.diff


1 Files Affected:

- (modified) libcxx/include/string (+1-1) 


``````````diff
diff --git a/libcxx/include/string b/libcxx/include/string
index c5c245fa297d353..4652a5d758dc80c 100644
--- a/libcxx/include/string
+++ b/libcxx/include/string
@@ -1138,7 +1138,7 @@ public:
 #if _LIBCPP_STD_VER >= 23
   basic_string& operator=(nullptr_t) = delete;
 #endif
-  _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_STRING_INTERNAL_MEMORY_ACCESS basic_string& operator=(value_type __c);
+  _LIBCPP_CONSTEXPR_SINCE_CXX20 basic_string& operator=(value_type __c);
 
   _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 iterator begin() _NOEXCEPT {
     return __make_iterator(__get_pointer());

``````````

</details>


https://github.com/llvm/llvm-project/pull/79574


More information about the libcxx-commits mailing list