[libcxx-commits] [libcxx] Remove unnecessary _LIBCPP_STRING_INTERNAL_MEMORY_ACCESS (PR #79574)

via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 26 02:43:44 PST 2024


https://github.com/AdvenamTacet created https://github.com/llvm/llvm-project/pull/79574

This macro is unnsecessary with `basic_string& operator=(value_type __c)`.

>From 0fb5f40b9c23fca7228ee7ec744bbbd3fdc60556 Mon Sep 17 00:00:00 2001
From: Advenam Tacet <advenam.tacet at trailofbits.com>
Date: Fri, 26 Jan 2024 11:40:34 +0100
Subject: [PATCH] Remove unnecessary _LIBCPP_STRING_INTERNAL_MEMORY_ACCESS

This macro is unnsecessary with `basic_string& operator=(value_type __c)`.
---
 libcxx/include/string | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libcxx/include/string b/libcxx/include/string
index c5c245fa297d353..4652a5d758dc80c 100644
--- a/libcxx/include/string
+++ b/libcxx/include/string
@@ -1138,7 +1138,7 @@ public:
 #if _LIBCPP_STD_VER >= 23
   basic_string& operator=(nullptr_t) = delete;
 #endif
-  _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_STRING_INTERNAL_MEMORY_ACCESS basic_string& operator=(value_type __c);
+  _LIBCPP_CONSTEXPR_SINCE_CXX20 basic_string& operator=(value_type __c);
 
   _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 iterator begin() _NOEXCEPT {
     return __make_iterator(__get_pointer());



More information about the libcxx-commits mailing list