[libcxx-commits] [libcxx] [libc++] Run the LLDB data formatter tests after libc++'s own tests (PR #119028)

via libcxx-commits libcxx-commits at lists.llvm.org
Fri Dec 6 12:42:42 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

<details>
<summary>Changes</summary>

It makes more sense to start testing libc++ with the latest compiler and only then to run the LLDB data formatter tests, since that provides more signal than starting with the data formatter tests.

---
Full diff: https://github.com/llvm/llvm-project/pull/119028.diff


1 Files Affected:

- (modified) libcxx/utils/ci/run-buildbot (+4-4) 


``````````diff
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index 3df7b00a8aa09d..a832380e16cd83 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -387,16 +387,16 @@ bootstrapping-build)
           -DLLVM_ENABLE_ASSERTIONS=ON \
           -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
 
-    step "Running the LLDB libc++ data formatter tests"
-    ${NINJA} -vC "${BUILD_DIR}" lldb-api-test-deps
-    ${BUILD_DIR}/bin/llvm-lit -sv --param dotest-args='--category libc++' "${MONOREPO_ROOT}/lldb/test/API"
-
     step "Running the libc++ and libc++abi tests"
     ${NINJA} -vC "${BUILD_DIR}" check-runtimes
 
     step "Installing libc++ and libc++abi to a fake location"
     ${NINJA} -vC "${BUILD_DIR}" install-runtimes
 
+    step "Running the LLDB libc++ data formatter tests"
+    ${NINJA} -vC "${BUILD_DIR}" lldb-api-test-deps
+    ${BUILD_DIR}/bin/llvm-lit -sv --param dotest-args='--category libc++' "${MONOREPO_ROOT}/lldb/test/API"
+
     ccache -s
 ;;
 generic-static)

``````````

</details>


https://github.com/llvm/llvm-project/pull/119028


More information about the libcxx-commits mailing list