[libcxx-commits] [libcxx] [libc++] Run the LLDB data formatter tests after libc++'s own tests (PR #119028)

[Louis Dionne via libcxx-commits]

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/119028

It makes more sense to start testing libc++ with the latest compiler and only then to run the LLDB data formatter tests, since that provides more signal than starting with the data formatter tests.

>From 4562ff28ef9f6c99a156019a49ef48dc2b231598 Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Fri, 6 Dec 2024 15:40:58 -0500
Subject: [PATCH] [libc++] Run the LLDB data formatter tests *after* libc++'s
 own tests

It makes more sense to start testing libc++ with the latest compiler
and only then to run the LLDB data formatter tests, since that provides
more signal than starting with the data formatter tests.
---
 libcxx/utils/ci/run-buildbot | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index 3df7b00a8aa09d..a832380e16cd83 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -387,16 +387,16 @@ bootstrapping-build)
           -DLLVM_ENABLE_ASSERTIONS=ON \
           -DLLVM_LIT_ARGS="-sv --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
 
-    step "Running the LLDB libc++ data formatter tests"
-    ${NINJA} -vC "${BUILD_DIR}" lldb-api-test-deps
-    ${BUILD_DIR}/bin/llvm-lit -sv --param dotest-args='--category libc++' "${MONOREPO_ROOT}/lldb/test/API"
-
     step "Running the libc++ and libc++abi tests"
     ${NINJA} -vC "${BUILD_DIR}" check-runtimes
 
     step "Installing libc++ and libc++abi to a fake location"
     ${NINJA} -vC "${BUILD_DIR}" install-runtimes
 
+    step "Running the LLDB libc++ data formatter tests"
+    ${NINJA} -vC "${BUILD_DIR}" lldb-api-test-deps
+    ${BUILD_DIR}/bin/llvm-lit -sv --param dotest-args='--category libc++' "${MONOREPO_ROOT}/lldb/test/API"
+
     ccache -s
 ;;
 generic-static)