[libcxx-commits] [libcxx] [libcxx] Marks transform_error.mandates.verify.cpp unsupported on msvc (PR #104635)

[via libcxx-commits]

================
@@ -13,8 +13,11 @@
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
 
 // With clang-cl, some warnings have a 'which is a Microsoft extension' suffix
-// which break the tests.
-// XFAIL: msvc
+// which break the tests. But #102851 will turn it into an error, making the test pass.
----------------
zeroomega wrote:

> If the diagnostic is always the same you can also make it `0-8`. It simply says we expect `0-1` errors. If there are different errors you can also just add a single `TODO` at the top of the file. Also, we should absolutely test with release versions of Clang, since we support them. We test _also_ with trunk.

Can I make the expect `0-1` errors only on msvc, what would the syntax looks like? For other platforms, test should through an error otherwise it should fail, we should guarantee that.

>  Also, we should absolutely test with release versions of Clang, since we support them. We test _also_ with trunk.
Not with Windows. As far as I can tell all windows bots for libcxx use release branch of clang. If they use ToT clang the test infra should have caught this issue.

https://github.com/llvm/llvm-project/pull/104635