[libcxx-commits] [libcxx] [libcxx] Marks transform_error.mandates.verify.cpp unsupported on msvc (PR #104635)
Nikolas Klauser via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Aug 19 11:06:37 PDT 2024
================
@@ -13,8 +13,11 @@
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
// With clang-cl, some warnings have a 'which is a Microsoft extension' suffix
-// which break the tests.
-// XFAIL: msvc
+// which break the tests. But #102851 will turn it into an error, making the test pass.
----------------
philnik777 wrote:
If the diagnostic is always the same you can also make it `0-8`. It simply says we expect `0-1` errors. If there are different errors you can also just add a single `TODO` at the top of the file. Also, we should absolutely test with release versions of Clang, since we support them. We test _also_ with trunk.
https://github.com/llvm/llvm-project/pull/104635
More information about the libcxx-commits
mailing list