[libcxx-commits] [libcxx] [libcxx] Marks transform_error.mandates.verify.cpp unsupported on msvc (PR #104635)
via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Aug 19 10:22:06 PDT 2024
================
@@ -13,8 +13,11 @@
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
// With clang-cl, some warnings have a 'which is a Microsoft extension' suffix
-// which break the tests.
-// XFAIL: msvc
+// which break the tests. But #102851 will turn it into an error, making the test pass.
----------------
zeroomega wrote:
Could you elaborate it a bit please? I am not very familiar syntax of `expected-error` and the '0-1' feature wasn't present in lit's document. My concern is that modify the test to use `expected-error 0-1` would require modifying every single test case. And ideally, adding a comment at each line that is modified. It is not a clean solution
IMO, the correct way to go forward is t overhaul libcxx test infrastructure to use ToT clang instead of release clang. It can solve a lot of inconsistency issues we have seen so far. But we all not that cannot be done in one day. Disabling this test and waiting for a clang roll on libcxx side is way going forward.
https://github.com/llvm/llvm-project/pull/104635
More information about the libcxx-commits
mailing list