[libcxx-commits] [libcxx] [libcxx] Marks transform_error.mandates.verify.cpp unsupported on msvc (PR #104635)

Nikolas Klauser via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 16 16:27:20 PDT 2024


================
@@ -13,8 +13,11 @@
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
 
 // With clang-cl, some warnings have a 'which is a Microsoft extension' suffix
-// which break the tests.
-// XFAIL: msvc
+// which break the tests. But #102851 will turn it into an error, making the test pass.
----------------
philnik777 wrote:

I think what we really want to do is add the diagnostics with a `expected-error 0-1` for the MSVC diagnostics and a comment that we can remove things in LLVM 22(?). As-is this will just result in the test being `UNSUPPORTED` indefinitely on MSVC.

https://github.com/llvm/llvm-project/pull/104635


More information about the libcxx-commits mailing list