[libcxx-commits] [libcxx] [libcxx] [modules] Add _LIBCPP_USING_IF_EXISTS on aligned_alloc (PR #89827)
Mark de Wever via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Apr 23 14:11:31 PDT 2024
https://github.com/mordante approved this pull request.
> This is missing e.g. on Windows. With this change, it's possible to make the libcxx std module work on mingw-w64 (although that requires a few fixes to those headers).
Great to hear!
> In the regular cstdlib header, we have _LIBCPP_USING_IF_EXISTS flagged on every single reexported function (since [a9c9183](https://github.com/llvm/llvm-project/commit/a9c9183ca42629fa83cdda297d1d30c7bc1d7c91)), but the modules seem to only have _LIBCPP_USING_IF_EXISTS set on a few individual functions.
I probably should properly propagate all of these to the modules.
(I'll add this to my todo list.) That should not block this patch, so LGTM!
https://github.com/llvm/llvm-project/pull/89827
More information about the libcxx-commits
mailing list