[libcxx-commits] [libcxx] [libcxx] [modules] Add _LIBCPP_USING_IF_EXISTS on aligned_alloc (PR #89827)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 23 13:50:05 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Martin Storsjö (mstorsjo)

<details>
<summary>Changes</summary>

This is missing e.g. on Windows. With this change, it's possible to make the libcxx std module work on mingw-w64 (although that requires a few fixes to those headers).

In the regular cstdlib header, we have _LIBCPP_USING_IF_EXISTS flagged on every single reexported function (since a9c9183ca42629fa83cdda297d1d30c7bc1d7c91), but the modules seem to only have _LIBCPP_USING_IF_EXISTS set on a few individual functions.

---
Full diff: https://github.com/llvm/llvm-project/pull/89827.diff


1 Files Affected:

- (modified) libcxx/modules/std.compat/cstdlib.inc (+1-1) 


``````````diff
diff --git a/libcxx/modules/std.compat/cstdlib.inc b/libcxx/modules/std.compat/cstdlib.inc
index a45a0a1caf8ba9..4783cbf5162390 100644
--- a/libcxx/modules/std.compat/cstdlib.inc
+++ b/libcxx/modules/std.compat/cstdlib.inc
@@ -25,7 +25,7 @@ export {
   using ::system;
 
   // [c.malloc], C library memory allocation
-  using ::aligned_alloc;
+  using ::aligned_alloc _LIBCPP_USING_IF_EXISTS;
   using ::calloc;
   using ::free;
   using ::malloc;

``````````

</details>


https://github.com/llvm/llvm-project/pull/89827


More information about the libcxx-commits mailing list